Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add MESSAGEix-Materials module #130

Closed
wants to merge 148 commits into from
Closed

Add MESSAGEix-Materials module #130

wants to merge 148 commits into from

Conversation

GamzeUnlu95
Copy link
Contributor

This PR migrates .model.material (i.e. MESSAGEix-Materials) from the (private) message_data repo to this message-ix-models package, following the procedure described in #89.

How to review

  • Read the diff and note that the CI checks all pass.
  • Run the build, solve, and report commands as described in the documentation.
  • Build the documentation and check if the page looks decent.
  • Ensure that changes/additions are self-documenting, i.e. that another
    developer (someone like the reviewer) will be able to understand what the code
    does in the future.

PR checklist

  • Continuous integration checks all ✅
  • Add or expand tests; coverage checks both ✅
  • Update doc/whatsnew.

@GamzeUnlu95 GamzeUnlu95 added the material MESSAGEix-Materials variant label Oct 13, 2023
@glatterf42
Copy link
Member

glatterf42 commented Oct 13, 2023

Hi @GamzeUnlu95, thanks for this PR :)
Did you know that the tools that perform the Code quality Test can be set up to run automatically, so that you don't really have to think about them again and this test doesn't slow down your workflow? If you tell me which editor you are using, I can help you with that :)

The branch also needs a rebase on to main, you can do that here or locally on your computer. In the first case, you would need to pull this PR after the rebase back to your machine; whereas in the second case you would have to force push your local changes after the rebase to this PR. If you don't feel comfortable doing either, please let me know 😃

@khaeru
Copy link
Member

khaeru commented May 24, 2024

@macflo8 @GamzeUnlu95 @glatterf42 as I understand, this was superseded by #188 and #189.

The key question is: is there anything remaining on this branch that was not included in those PRs, yet should be preserved on main?

  • If yes, I would suggest to mention as 1 or more comments/checklist items on Test and improve .model.material #194.
    • These could be linked to this branch, or their original location on a message_data branch.
  • Whether yes or no, we can then close this PR (without merging), and possibly delete the associated branch.

@macflo8
Copy link
Contributor

macflo8 commented May 24, 2024

I think there are no changes that need to be carried over from this branch, but I will check and confirm whether we can close this PR or need to add items to #194.

@khaeru
Copy link
Member

khaeru commented Sep 26, 2024

As discussed at today's MESSAGE meeting:

@khaeru khaeru closed this Sep 26, 2024
@khaeru khaeru added the archive PR not merged but branch preserved for reference label Sep 26, 2024
macflo8 added a commit that referenced this pull request Oct 8, 2024
macflo8 added a commit that referenced this pull request Oct 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
archive PR not merged but branch preserved for reference material MESSAGEix-Materials variant
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants